[PATCH] D38482: TargetMachine: Use LLVMTargetMachine in CodeGen

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

I generally like the direction of the cleanup. A few high level questions:

1. You say that this is to distinguish targets that *do* use LLVM's lib/CodeGen from those that do not. Do you mean entire targets that do not? Or do you mean just *components* of targets that do not depend on it like the target's MC layer?

2. If in #1 you mean actual targets -- are there any left now that the C backend is gone? What are these targets? I wonder if we could simplify things by collapsing a no longer necessary layer.

3. If we can't eliminate the distinction here completely, are there better names than `TargetMachine` and `LLVMTargetMachine` that we could give these? I'm guessing a good name will be informed by the answers to the above two questions and the reason we're keeping the distinction in place.

4. Any ideas how we could improve comments (or the design) to avoid regressing this (again) in the future?


Repository:
  rL LLVM

https://reviews.llvm.org/D38482