[PATCH] D38461: [MC] - Don't assert when non-english characters are used.

[Rui Ueyama via llvm-commits]

On Mon, Oct 2, 2017 at 4:25 PM, Rafael Avila de Espindola via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Reid Kleckner via Phabricator <reviews at reviews.llvm.org> writes:
>
> > rnk added a comment.
> >
> > cppreference suggests writing our own wrapper to avoid this issue:
> http://en.cppreference.com/w/cpp/string/byte/isdigit
> >
> > I'd suggest adding `llvm::isDigit` and `llvm::isHexDigit` in
> StringExtras.h next to our other hex digit conversion routines, so we don't
> have to repeat this surprising cast everywhere.
>
> I agree.
>

Please add llvm::isAlpha and llvm::isAlnum too. We use these functions in
lld.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171002/994ec361/attachment.html>