[PATCH] D38469: CodeView symbol dumper: use symbolic names for registers

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: lib/DebugInfo/CodeView/SymbolDumper.cpp:321
+  W.printEnum("BaseRegister", uint16_t(DefRangeRegisterRel.Hdr.Register),
+              getRegisterNames());
   W.printBoolean("HasSpilledUDTMember",
----------------
rnk wrote:
> ... we already had this? >_<
Looks like it came in with the PDB stuff in r270628.


================
Comment at: test/DebugInfo/COFF/fp-stack.ll:15
 ; OBJ:    DefRangeRegisterSym {
-; OBJ:      Register: 128
+; OBJ:      Register: 0x80
 ; OBJ:      MayHaveNoName: 0
----------------
hans wrote:
> This one is a bit mysterious.. 128 / 0x80 is not in the RegisterId. Is the enum missing floating-point registers perhaps?
Oh, I guess it's FP0. I'll see if I can add it to the enum in a follow-up.


https://reviews.llvm.org/D38469