[PATCH] D38469: CodeView symbol dumper: use symbolic names for registers

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 10:33:46 PDT 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/DebugInfo/CodeView/SymbolDumper.cpp:321
+  W.printEnum("BaseRegister", uint16_t(DefRangeRegisterRel.Hdr.Register),
+              getRegisterNames());
   W.printBoolean("HasSpilledUDTMember",
----------------
... we already had this? >_<


https://reviews.llvm.org/D38469





More information about the llvm-commits mailing list