[PATCH] D38466: [ TargetLowering, AMDGPU] Use the return value of UpdateNodeOperands();

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/simplifydemandedbits-recursion.ll:1
+; RUN: (ulimit -t 5; llc -march=amdgcn < %s | FileCheck -check-prefix=GCN %s)
+
----------------
Does this actually work? I've never seen another test use ulimit or a sub shell. 5 seconds seems high also.


================
Comment at: test/CodeGen/AMDGPU/simplifydemandedbits-recursion.ll:74
+  %34 = phi i32 [ %11, %28 ], [ undef, %33 ]
+  %35 = getelementptr inbounds [462 x float], [462 x float] addrspace(3)* @0, i32 0, i32 %34
+  %36 = load float, float addrspace(3)* %35, align 4
----------------
Run instnamer on this test


https://reviews.llvm.org/D38466