[PATCH] D38355: [X86][NFC] Add X86CmovConverterPass to the pass registry
Amjad Aboud via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 2 10:02:38 PDT 2017
aaboud marked an inline comment as done.
aaboud added inline comments.
================
Comment at: lib/Target/X86/X86CmovConversion.cpp:84
+ X86CmovConverterPass() : MachineFunctionPass(ID) {
+ initializeX86CmovConverterPassPass(*PassRegistry::getPassRegistry());
+ }
----------------
craig.topper wrote:
> craig.topper wrote:
> > Maybe do this in LLVMInitializeX86Target in X86TargetMachine.cpp? That's where we're doing the other passes that are registered.
> Or maybe we need to do it in both places?
Cannot do in both places, you can register a pass only once.
I moved the registration to the LLVMInitializeX86Target as you suggested.
https://reviews.llvm.org/D38355
More information about the llvm-commits
mailing list