[PATCH] D38467: AMDGPU: Remove global isGCN predicates

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 10:01:56 PDT 2017


arsenm created this revision.
Herald added subscribers: arichardson, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl, sdardis.

These are problematic because they apply to everything,
and can easily clobber whatever more specific predicate
you are trying to add to a function.

      

Currently instructions use SubtargetPredicate/PredicateControl
to apply this to patterns applied to an instruction definition,
but not to free standing Pats. Add a wrapper around Pat
so the special PredicateControls requirements can be appended
to the final predicate list like how Mips does it.


https://reviews.llvm.org/D38467

Files:
  lib/Target/AMDGPU/AMDGPU.td
  lib/Target/AMDGPU/AMDGPUInstructions.td
  lib/Target/AMDGPU/BUFInstructions.td
  lib/Target/AMDGPU/CaymanInstructions.td
  lib/Target/AMDGPU/DSInstructions.td
  lib/Target/AMDGPU/EvergreenInstructions.td
  lib/Target/AMDGPU/FLATInstructions.td
  lib/Target/AMDGPU/MIMGInstructions.td
  lib/Target/AMDGPU/R600InstrFormats.td
  lib/Target/AMDGPU/R600Instructions.td
  lib/Target/AMDGPU/SIInstrFormats.td
  lib/Target/AMDGPU/SIInstructions.td
  lib/Target/AMDGPU/SMInstructions.td
  lib/Target/AMDGPU/SOPInstructions.td
  lib/Target/AMDGPU/VOP1Instructions.td
  lib/Target/AMDGPU/VOP2Instructions.td
  lib/Target/AMDGPU/VOP3Instructions.td
  lib/Target/AMDGPU/VOP3PInstructions.td
  lib/Target/AMDGPU/VOPCInstructions.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38467.117379.patch
Type: text/x-patch
Size: 102161 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171002/0479f496/attachment.bin>


More information about the llvm-commits mailing list