[PATCH] D38461: [MC] - Don't assert when non-english characters are used.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 09:31:56 PDT 2017


davide added a comment.

In https://reviews.llvm.org/D38461#885923, @rnk wrote:

> cppreference suggests writing our own wrapper to avoid this issue: http://en.cppreference.com/w/cpp/string/byte/isdigit
>
> I'd suggest adding `llvm::isDigit` and `llvm::isHexDigit` in StringExtras.h next to our other hex digit conversion routines, so we don't have to repeat this surprising cast everywhere.


Yes, that sounds the best solution actually.


https://reviews.llvm.org/D38461





More information about the llvm-commits mailing list