[PATCH] D38457: [llvm-cov] Hide files with no coverage from the index when filtering by name

[Sean Eveson via Phabricator via llvm-commits]

seaneveson added inline comments.


================
Comment at: test/tools/llvm-cov/dir-with-filtering.test:38
+RUN: llvm-cov show %S/Inputs/dir-with-filtering.covmapping -o %t.text_one_func -instr-profile %t.profdata -path-equivalence=/tmp,%S/Inputs -name=main
+RUN: FileCheck -input-file=%t.text_one_func/index.txt %s -check-prefix=TEXT-INDEX-ONE-FILE
+
----------------
vsk wrote:
> This test looks like it would pass without this patch's functionality change. Could you "CHECK-NOT" against "Files which ..."?
The test checks that `dir-with-filtering2.cpp` does not appear in the index file. Before the change it appears listed under the "Files which ..." sections, so the test doesn't pass.

I'll add a check for "Files which ..." since that shouldn't be in the output either.

Thanks for the review!


https://reviews.llvm.org/D38457