[PATCH] D38453: [dwarfdump] Verify that unit type matches root DIE

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:315
+    case dwarf::DW_UT_split_compile:
+    case dwarf::DW_UT_split_type:
+      return Tag == dwarf::DW_TAG_imported_unit;
----------------
Is that correct? I thought imported units are an orthogonal concept to split units. (But I may be wrong here)


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:187
+  if (!Die) {
+    error() << "Compilation unit without DIE.\n";
+    NumUnitErrors++;
----------------
Perhaps: `Compilation unit header without any DIEs?`


Repository:
  rL LLVM

https://reviews.llvm.org/D38453