[PATCH] D38448: [AsmParser] Support GAS's .print directive

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 06:07:37 PDT 2017


javed.absar added inline comments.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:542
+    DK_END,
+    DK_PRINT
   };
----------------
coby wrote:
> javed.absar wrote:
> > Putting DK_PRINT beyond DK_END doesn't seem right
> ah.. DK_END stands for the ".end" directive and holds no other semantical purposes.. but I can see your point :)
> will be relocated.
> anything else other than this?
OK from my side. Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D38448





More information about the llvm-commits mailing list