[PATCH] D38407: [ELF] - Do --hash-style=both by default.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 05:29:17 PDT 2017


>In addition to that, I would probably feel more comfortable if the test
>just changed the command line. It is hard to review so many test changes
>to see that they still test the desired property.
>
>Cheers,
>Rafael

Does it make sence to split changing of testcases into several separate patches ?
(either before hash style option default value change or after that)
Or do you prefer just adding --hash-style="sysv" to all old tests and leave it as is ?

George.


More information about the llvm-commits mailing list