[PATCH] D38154: [PassManager] Run global opts after the inliner

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:511
+    // benefits generally outweight the cost, making the whole pipeline
+    // faster. See PR34652.
+    PM.add(createGlobalOptimizerPass());
----------------
mehdi_amini wrote:
> chandlerc wrote:
> > mehdi_amini wrote:
> > > Did you run any benchmarks to conclude that it is faster? (The referenced PR seems to only mention some specific IR generated by Rust IIUC)
> > > 
> > I chatted some with Davide about this on IRC and he had seen similar issues with C++. Fundamentally, I would expect the same pattern to be able to come up in C++.
> OK, it'd be nice to have a test-case with this patch though.
Testing this feature is ... a little hard with the current infrastructure.
I could write an -O2 test, if you'd like, but it's unclear how robust it is (in particular, if something before changes).


https://reviews.llvm.org/D38154