[PATCH] D38418: Add ELFOSABI_FIRST_ARCH, ELFOSABI_LAST_ARCH and start using those in llvm-readobj

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 29 13:04:12 PDT 2017


> Index: tools/llvm-readobj/ELFDumper.cpp
> ===================================================================
> --- tools/llvm-readobj/ELFDumper.cpp
> +++ tools/llvm-readobj/ELFDumper.cpp
> @@ -3519,7 +3519,9 @@
>        W.printNumber("FileVersion", e->e_ident[ELF::EI_VERSION]);
>  
>        // Handle architecture specific OS/ABI values.
> -      if (e->e_machine == ELF::EM_AMDGPU)
> +      if (e->e_machine == ELF::EM_AMDGPU &&
> +          e->e_ident[ELF::EI_OSABI] >= ELF::ELFOSABI_FIRST_ARCH &&
> +          e->e_ident[ELF::EI_OSABI] <= ELF::ELFOSABI_LAST_ARCH)
>          W.printEnum("OS/ABI", e->e_ident[ELF::EI_OSABI],
>                      makeArrayRef(AMDGPUElfOSABI));

Current trunk has

      // Handle architecture specific OS/ABI values.
      if (e->e_machine == ELF::EM_AMDGPU &&
          e->e_ident[ELF::EI_OSABI] == ELF::ELFOSABI_AMDGPU_HSA)

please rebase.

Cheers,
Rafael


More information about the llvm-commits mailing list