[llvm] r314530 - AMDGPU: fix bad test exposed by r314522

Nicolai Haehnle via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 29 09:07:05 PDT 2017


Author: nha
Date: Fri Sep 29 09:07:05 2017
New Revision: 314530

URL: http://llvm.org/viewvc/llvm-project?rev=314530&view=rev
Log:
AMDGPU: fix bad test exposed by r314522

The test attempts to use -1 as carry-in for v_addc_*.

Before writing r314522, I did actually test this on real hardware,
and found that it doesn't work. So r314522 is correct in restricting
the carry-in operand: just remove those tests to make things pass
again.

Modified:
    llvm/trunk/test/MC/AMDGPU/vop2.s

Modified: llvm/trunk/test/MC/AMDGPU/vop2.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AMDGPU/vop2.s?rev=314530&r1=314529&r2=314530&view=diff
==============================================================================
--- llvm/trunk/test/MC/AMDGPU/vop2.s (original)
+++ llvm/trunk/test/MC/AMDGPU/vop2.s Fri Sep 29 09:07:05 2017
@@ -347,14 +347,6 @@ v_addc_u32 v1, s[0:1], v2, v3, s[2:3]
 // VI: v_addc_u32_e64 v1, s[0:1], v2, v3, s[2:3] ; encoding: [0x01,0x00,0x1c,0xd1,0x02,0x07,0x0a,0x00]
 v_addc_u32_e64 v1, s[0:1], v2, v3, s[2:3]
 
-// SI: v_addc_u32_e64 v1, s[0:1], v2, v3, -1 ; encoding: [0x01,0x00,0x50,0xd2,0x02,0x07,0x06,0x03]
-// VI: v_addc_u32_e64 v1, s[0:1], v2, v3, -1 ; encoding: [0x01,0x00,0x1c,0xd1,0x02,0x07,0x06,0x03]
-v_addc_u32_e64 v1, s[0:1], v2, v3, -1
-
-// SI: v_addc_u32_e64 v1, vcc, v2, v3, -1 ; encoding: [0x01,0x6a,0x50,0xd2,0x02,0x07,0x06,0x03]
-// VI: v_addc_u32_e64 v1, vcc, v2, v3, -1 ; encoding: [0x01,0x6a,0x1c,0xd1,0x02,0x07,0x06,0x03]
-v_addc_u32_e64 v1, vcc, v2, v3, -1
-
 // SI: v_addc_u32_e64 v1, vcc, v2, v3, vcc ; encoding: [0x01,0x6a,0x50,0xd2,0x02,0x07,0xaa,0x01]
 // VI: v_addc_u32_e64 v1, vcc, v2, v3, vcc ; encoding: [0x01,0x6a,0x1c,0xd1,0x02,0x07,0xaa,0x01]
 v_addc_u32_e64 v1, vcc, v2, v3, vcc




More information about the llvm-commits mailing list