[PATCH] D38395: [dwarfdump][NFC] Consistent printing of address ranges
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 29 08:10:39 PDT 2017
aprantl added inline comments.
================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRangeList.cpp:21
+raw_ostream &llvm::operator<<(raw_ostream &OS, const DWARFAddressRange &R) {
+ return OS << format("[0x%16.16" PRIx64 " - 0x%16.16" PRIx64 ")", R.LowPC,
+ R.HighPC);
----------------
I think we should use `", "` instead of `"- "`. IMHO either it's `start - end` or `[start, end)`
Repository:
rL LLVM
https://reviews.llvm.org/D38395
More information about the llvm-commits
mailing list