[PATCH] D30529: [RFC][GlobalISel] Enable legalizing non-power-of-2 sized types.
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 29 07:39:30 PDT 2017
aemerson added inline comments.
================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:342
+ const unsigned OpcodeIdx = Opcode - FirstOp;
+ if (NumElements2Actions[OpcodeIdx].find(ElementSize) ==
+ NumElements2Actions[OpcodeIdx].end())
----------------
Not to block this patch, but std::map seems a little heavy handed for use here, given I think its a BST underneath. I'm assuming DenseMap won't work because of you need to define another tombstone key. Maybe use unordered_map or a simple vector?
https://reviews.llvm.org/D30529
More information about the llvm-commits
mailing list