[PATCH] D38388: [DAGCombiner, x86] convert insertelement of bitcasted vector into shuffle

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13787
+  // Step 3: Shuffle in the padded subvector.
+  return DAG.getVectorShuffle(VT, DL, DestVec, PaddedSubVec, ShufMaskVals);
+}
----------------
We need to test for isShuffleMaskLegal here and I think it will remove the need for shouldConvertInsSubVecToShuffle


https://reviews.llvm.org/D38388