[llvm] r314454 - Fix -Werror build.

[Yung, Douglas via llvm-commits]

That did fix it, thanks!

Douglas Yung

From: Lang Hames [mailto:lhames at gmail.com]
Sent: Thursday, September 28, 2017 22:06
To: Yung, Douglas
Cc: llvm-commits at lists.llvm.org
Subject: Re: [llvm] r314454 - Fix -Werror build.

Hi Douglas,

I don’t know if you are aware,

I was, but lost connectivity on my commute and could commit the fix. My apologies. This should be fixed by r314490.

- Lang.


On Thu, Sep 28, 2017 at 8:40 PM, Yung, Douglas <douglas.yung at sony.com<mailto:douglas.yung at sony.com>> wrote:
Hi Lang, I don’t know if you are aware, but the PS4 Windows bot is still broken from your change even with this fix.

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12393: (building r314486)

C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(261): error C2065: 'ObjLayer': undeclared identifier
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(261): error C2651: 'unknown-type': left of '::' must be a class, struct or union
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(261): error C2144: syntax error: 'unknown-type' should be preceded by ')'
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(261): error C3260: 'type': skipping unexpected token(s) before lambda body
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(263): error C2664: 'llvm::orc::RTDyldObjectLinkingLayer::RTDyldObjectLinkingLayer(llvm::orc::RTDyldObjectLinkingLayer &&)': cannot convert argument 2 from '`anonymous-namespace'::RTDyldObjectLinkingLayerExecutionTest_TestNotifyLoadedSignature_Test::TestBody::<lambda_0c2aeba18b2343eb100eeaee81fedf3a>' to 'llvm::orc::RTDyldObjectLinkingLayer::NotifyLoadedFtor'
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(263): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called


Douglas Yung

From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org<mailto:llvm-commits-bounces at lists.llvm.org>] On Behalf Of Lang Hames via llvm-commits
Sent: Thursday, September 28, 2017 19:13
To: Evgeniy Stepanov
Cc: Commit Messages and Patches for LLVM
Subject: Re: [llvm] r314454 - Fix -Werror build.

Oops! Thanks Evgeniy!

- Lang.

On Thu, Sep 28, 2017 at 12:43 PM, Evgeniy Stepanov via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
Author: eugenis
Date: Thu Sep 28 12:43:53 2017
New Revision: 314454

URL: http://llvm.org/viewvc/llvm-project?rev=314454&view=rev
Log:
Fix -Werror build.

/code/llvm-project/llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp:260:38: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
                                    [this](decltype(ObjLayer)::ObjHandleT,

Modified:
    llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp

Modified: llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp?rev=314454&r1=314453&r2=314454&view=diff
==============================================================================
--- llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp (original)
+++ llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp Thu Sep 28 12:43:53 2017
@@ -256,11 +256,11 @@ TEST_F(RTDyldObjectLinkingLayerExecution
 }

 TEST_F(RTDyldObjectLinkingLayerExecutionTest, TestNotifyLoadedSignature) {
-  RTDyldObjectLinkingLayer ObjLayer([]() { return nullptr; },
-                                    [this](decltype(ObjLayer)::ObjHandleT,
-                                           const decltype(ObjLayer)::ObjectPtr &obj,
-                                           const RuntimeDyld::LoadedObjectInfo &info) {
-                                    });
+  RTDyldObjectLinkingLayer ObjLayer(
+      []() { return nullptr; },
+      [](decltype(ObjLayer)::ObjHandleT,
+         const decltype(ObjLayer)::ObjectPtr &obj,
+         const RuntimeDyld::LoadedObjectInfo &info) {});
 }

 } // end anonymous namespace


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170929/7e0a7216/attachment.html>