[PATCH] D38387: AMDGPU: Add ELFOSABI_AMDGPU_MESA3D

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: docs/AMDGPUUsage.rst:404
 ``e_ident[EI_OSABI]``
   One of two AMD GPU architecture specific OS ABI:
 
----------------
```
One of the following AMD GPU architecture specific OS ABIs:
```


================
Comment at: docs/AMDGPUUsage.rst:412-413
 
+  * ``ELFOSABI_AMDGPU_MESA3D`` is used to specify that the code object conforms
+    to the AMD MESA runtime ABI for AMD GCN GPUs (GFX6+).
+
----------------
Is it necessary to mention "for AMD GCN GPUs (GFX6+)" as the other ones above do not, and presumably it would be ok for the R600 architecture to use this ABI too if it wanted to?


================
Comment at: docs/AMDGPUUsage.rst:425-426
 
+  * ``ELFABIVERSION_AMDGPU_MESA3D`` is used to specify the version of AMD MESA
+    runtime ABI for AMD GCN GPUs (GFX6+).
+
----------------
Same comment as above.


================
Comment at: include/llvm/Object/ELFObjectFile.h:1071-1076
       switch (EF.getHeader()->e_ident[ELF::EI_OSABI]) {
       case ELF::ELFOSABI_AMDGPU_HSA:
       case ELF::ELFOSABI_AMDGPU_PAL:
+      case ELF::ELFOSABI_AMDGPU_MESA3D:
         return Triple::amdgcn;
       }
----------------
Same comment as in other patch.


https://reviews.llvm.org/D38387