[llvm] r314436 - [ORC] Fix the type of RTDyldObjectLinkingLayer::NotifyLoadedFtor.
Yung, Douglas via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 28 18:31:30 PDT 2017
Hi, this commit is failing to build on the PS4 Windows bot with an error.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12374:
FAILED: unittests/ExecutionEngine/Orc/CMakeFiles/OrcJITTests.dir/RTDyldObjectLinkingLayerTest.cpp.obj
C:\PROGRA~2\MICROS~1.0\VC\bin\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_FILE_OFFSET_BITS=64 -D_HAS_EXCEPTIONS=0 -D_LARGEFILE_SOURCE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iunittests\ExecutionEngine\Orc -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc -Iinclude -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\utils\unittest\googletest\include -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\utils\unittest\googlemock\include /DWIN32 /D_WINDOWS /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4324 -w14062 -we4238 /MD /O2 /Ob2 -UNDEBUG /EHs-c- /GR- /showIncludes /Founittests\ExecutionEngine\Orc\CMakeFiles\OrcJITTests.dir\RTDyldObjectLinkingLayerTest.cpp.obj /Fdunittests\ExecutionEngine\Orc\CMakeFiles\OrcJITTests.dir\ /FS -c C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(260): error C2065: 'ObjLayer': undeclared identifier
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(260): error C2651: 'unknown-type': left of '::' must be a class, struct or union
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(260): error C2144: syntax error: 'unknown-type' should be preceded by ')'
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(260): error C3260: 'type': skipping unexpected token(s) before lambda body
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(263): error C2664: 'llvm::orc::RTDyldObjectLinkingLayer::RTDyldObjectLinkingLayer(llvm::orc::RTDyldObjectLinkingLayer &&)': cannot convert argument 2 from '`anonymous-namespace'::RTDyldObjectLinkingLayerExecutionTest_TestNotifyLoadedSignature_Test::TestBody::<lambda_0c2aeba18b2343eb100eeaee81fedf3a>' to 'llvm::orc::RTDyldObjectLinkingLayer::NotifyLoadedFtor'
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\unittests\ExecutionEngine\Orc\RTDyldObjectLinkingLayerTest.cpp(263): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
Can you take a look?
Douglas Yung
> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf Of
> Lang Hames via llvm-commits
> Sent: Thursday, September 28, 2017 10:43
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r314436 - [ORC] Fix the type of
> RTDyldObjectLinkingLayer::NotifyLoadedFtor.
>
> Author: lhames
> Date: Thu Sep 28 10:43:07 2017
> New Revision: 314436
>
> URL: http://llvm.org/viewvc/llvm-project?rev=314436&view=rev
> Log:
> [ORC] Fix the type of RTDyldObjectLinkingLayer::NotifyLoadedFtor.
>
> Bug found by Stefan Granitz. Thanks Stefan!
>
>
>
> Modified:
> llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h
> llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h
> llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp
>
> Modified:
> llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h
> ?rev=314436&r1=314435&r2=314436&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h
> (original)
> +++ llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer
> +++ .h Thu Sep 28 10:43:07 2017
> @@ -99,8 +99,9 @@ public:
> using RTDyldObjectLinkingLayerBase::ObjectPtr;
>
> /// @brief Functor for receiving object-loaded notifications.
> - using NotifyLoadedFtor = std::function<void(ObjHandleT, const ObjectPtr
> &Obj,
> - const LoadedObjectInfo &)>;
> + using NotifyLoadedFtor =
> + std::function<void(ObjHandleT, const ObjectPtr &Obj,
> + const RuntimeDyld::LoadedObjectInfo &)>;
>
> /// @brief Functor for receiving finalization notifications.
> using NotifyFinalizedFtor = std::function<void(ObjHandleT)>;
>
> Modified: llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h?rev=314436&r1
> =314435&r2=314436&view=diff
> ==============================================================================
> --- llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h (original)
> +++ llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h Thu Sep 28
> +++ 10:43:07 2017
> @@ -341,7 +341,7 @@ private:
>
> void operator()(RTDyldObjectLinkingLayerBase::ObjHandleT H,
> const RTDyldObjectLinkingLayer::ObjectPtr &Obj,
> - const LoadedObjectInfo &Info) const {
> + const RuntimeDyld::LoadedObjectInfo &Info) const {
> M.UnfinalizedSections[H] = std::move(M.SectionsAllocatedSinceLastLoad);
> M.SectionsAllocatedSinceLastLoad = SectionAddrSet();
> M.MemMgr->notifyObjectLoaded(&M, *Obj->getBinary());
>
> Modified:
> llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.
> cpp?rev=314436&r1=314435&r2=314436&view=diff
> ==============================================================================
> --- llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp
> (original)
> +++ llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTes
> +++ t.cpp Thu Sep 28 10:43:07 2017
> @@ -255,4 +255,12 @@ TEST_F(RTDyldObjectLinkingLayerExecution
> "(multiple unrelated objects loaded prior to finalization)"; }
>
> +TEST_F(RTDyldObjectLinkingLayerExecutionTest,
> +TestNotifyLoadedSignature) {
> + RTDyldObjectLinkingLayer ObjLayer([]() { return nullptr; },
> + [this](decltype(ObjLayer)::ObjHandleT,
> + const
> decltype(ObjLayer)::ObjectPtr &obj,
> + const
> RuntimeDyld::LoadedObjectInfo &info) {
> + }); }
> +
> } // end anonymous namespace
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list