[PATCH] D37269: Add support for custom loaders to the sanitizer symbolizer

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 28 13:36:15 PDT 2017


fjricci reopened this revision.
fjricci added a comment.
This revision is now accepted and ready to land.

This caused a hang on one of the linux buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/4146

I'm not sure why this would affect only that buildbot, as it seems like a pretty generic one. I don't see any linux issues locally. My only idea is potentially that `initialized` could introduce a race condition leading to double-initialization, but I don't understand how two threads could be using the ListOfModules at the same time (or why that would cause a hang instead of data corruption/leaking). I can try introducing a mutex there if it seems problematic.


Repository:
  rL LLVM

https://reviews.llvm.org/D37269





More information about the llvm-commits mailing list