[PATCH] D38119: [XRay][compiler-rt] Use a hand-written circular buffer in BufferQueue
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 28 11:03:34 PDT 2017
dblaikie added a comment.
Why all the logging & test changes in the latest update? Did they slip in accidentally?
================
Comment at: lib/xray/xray_buffer_queue.cc:30
+ Next(Buffers.get()), First(nullptr) {
+ for (size_t I = 0; I < N; ++I) {
+ auto &T = Buffers[I];
----------------
Looks like LLVM uses lowercase 'i' for integer counters much more often than uppercase 'I' (the uppercase is often used for iterators, but not so often used for integer counters).
(& probably "!=" rather than "<" I would guess is more idiomatic in LLVM)
https://reviews.llvm.org/D38119
More information about the llvm-commits
mailing list