[PATCH] D38368: [dwarfdump][NFC] Consistent errors and warnings with --verify

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:328
       ++NumErrors;
-      OS << format("error: DIE has overlapping address ranges: [0x%08" PRIx64
-                   " - 0x%08" PRIx64 "] and [0x%08" PRIx64 " - 0x%08" PRIx64
-                   "].\n",
-                   Range.LowPC, Range.HighPC, IntersectingRange->LowPC,
-                   IntersectingRange->HighPC);
+      error() << format("DIE has overlapping address ranges: [0x%08" PRIx64
+                        " - 0x%08" PRIx64 "] and [0x%08" PRIx64
----------------
This doesn't belong in this review, but I just noticed that we also should define a similar helper for formatting a range. I think at some point we all agreed that half-open ranges should be formatted `[start,end)`.


================
Comment at: test/tools/llvm-dwarfdump/X86/verify_unit_header_chain.s:7
+# CHECK-NEXT: error: Units[1] - start offset: 0x0000000d
+# CHECK-NEXT:	note: The unit type encoding is not valid.
+# CHECK-NEXT: note: The address size is unsupported.
----------------
extra whitespace


Repository:
  rL LLVM

https://reviews.llvm.org/D38368