[PATCH] D38298: A logic to copy LLVM licences into docker images.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D38298#883177, @klimek wrote:

> In https://reviews.llvm.org/D38298#883091, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D38298#883025, @klimek wrote:
> >
> > > "make install" is not primarily a distribution mechanism, docker is (most folks upload their docker images to public registries without thinking much about this).
> >
> >
> > I'm not sure why "primarily a distribution mechanism matters? How is one suppose to distribute?
>
>
> docker push to a public registry?


Not much different from pushing a .tar.gz resulting from the install to llvm.org (which is actually that how I package my internal distribution right now, luckily I don't distribute outside the company, so I haven't hit the license problem...).

>>> Docker to me is more similar to having debian or rpm generating rules; if we had those, I'd also argue that we should include the licenses in the right places of these.
>> 
>> I'm using Docker in my CI purely for reproducibility. Again separation of concerns: mixing the tool (Docker) with the purpose (distribution) does not seem right to me.
> 
> Well, we definitely want a license label in the docker image / want the right license field set for .deb / other distribution mechanisms, so I don't think there's full separation of concerns anyway.

We want a license in every distribution: using docker, debian or not. I'm not sure why duplicating the logic everywhere would be a good thing?

>> I just checked and the pre-built releases on llvm.org don't ship with the license files (but one, by accident I guess).
>> 
>> So again a CMake option with `make install` seems a far better place to me. Second to this, release scripts in llvm, decoupled from Docker.
> 
> Where would license files go on a make install?

"$CLANG_INSTALL_DIR/share/llvm/licenses"? Eventually make the path it an option?


https://reviews.llvm.org/D38298