[PATCH] D38298: A logic to copy LLVM licences into docker images.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D38298#883025, @klimek wrote:

> "make install" is not primarily a distribution mechanism, docker is (most folks upload their docker images to public registries without thinking much about this).


I'm not sure why "primarily a distribution mechanism matters? How is one suppose to distribute?

> Docker to me is more similar to having debian or rpm generating rules; if we had those, I'd also argue that we should include the licenses in the right places of these.

I'm using Docker in my CI purely for reproducibility. Again separation of concerns: mixing the tool (Docker) with the purpose (distribution) does not seem right to me.

I just checked and the pre-built releases on llvm.org don't ship with the license files (but one, by accident I guess).

So again a CMake option with `make install` seems a far better place to me. Second to this, release scripts in llvm, decoupled from Docker.


https://reviews.llvm.org/D38298