[PATCH] D38276: [X86] Remove dead code from X86ISelDAGToDAG.cpp multiply handling

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 28 00:28:39 PDT 2017


craig.topper updated this revision to Diff 116929.
craig.topper added a comment.

Breaking this up into smaller pieces. Starting with just the X86ISD::UMUL piece since that one is easy.


https://reviews.llvm.org/D38276

Files:
  lib/Target/X86/X86ISelDAGToDAG.cpp


Index: lib/Target/X86/X86ISelDAGToDAG.cpp
===================================================================
--- lib/Target/X86/X86ISelDAGToDAG.cpp
+++ lib/Target/X86/X86ISelDAGToDAG.cpp
@@ -2594,7 +2594,7 @@
     unsigned LoReg;
     switch (NVT.SimpleTy) {
     default: llvm_unreachable("Unsupported VT!");
-    case MVT::i8:  LoReg = X86::AL;  Opc = X86::MUL8r; break;
+    // MVT::i8 is handled by X86ISD::UMUL8.
     case MVT::i16: LoReg = X86::AX;  Opc = X86::MUL16r; break;
     case MVT::i32: LoReg = X86::EAX; Opc = X86::MUL32r; break;
     case MVT::i64: LoReg = X86::RAX; Opc = X86::MUL64r; break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38276.116929.patch
Type: text/x-patch
Size: 611 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170928/c8c87281/attachment.bin>


More information about the llvm-commits mailing list