[PATCH] D32844: [XRay] [compiler-rt] FDR logging arg1 handler
Dean Michael Berris via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 27 22:07:01 PDT 2017
dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: test/xray/TestCases/Linux/fdr-mode.cc:100-101
+// UNWRITE: records:
+// UNWRITE-NEXT: - { type: 0, func-id: [[FIDARG:[0-9]+]], function: 'fArg(int)', args: [ 1 ], cpu: {{.*}}, thread: [[THREAD2:[0-9]+]], kind: function-enter-arg, tsc: {{[0-9]+}} }
+// UNWRITE-NEXT: - { type: 0, func-id: [[FIDARG]], function: 'fArg(int)', cpu: {{.*}}, thread: [[THREAD2]], kind: function-exit, tsc: {{[0-9]+}} }
// UNWRITE-NOT: function-enter
----------------
Probably use UNWRITE-DAG here instead, similar to how we use TRACE-DAG above.
https://reviews.llvm.org/D32844
More information about the llvm-commits
mailing list