[PATCH] D38137: [ELF] Simpler scheme for handling common symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Symbols.cpp:282
     : Defined(SymbolBody::DefinedCommonKind, Name, /*IsLocal=*/false, StOther,
               Type),
+      Alignment(Alignment), Size(Size) {}
----------------
I don't think this is how clang-format formats.


================
Comment at: ELF/SyntheticSections.cpp:73
+    // don't have to care about DefinedCommon symbols beyond this point.
+    replaceBody<DefinedRegular>(S, Sym->getFile(), Sym->getName(), (bool)Sym->IsLocal,
+                                Sym->StOther, Sym->Type, 0,
----------------
80 col.


https://reviews.llvm.org/D38137