[PATCH] D38239: [ELF] - Define linkerscript symbols early.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:183-185
+  if (!CurAddressState)
+    return B ? B : addDummyRegular(Cmd);
+  return addRegular(Cmd);
----------------
I do not understand this change.


================
Comment at: ELF/LinkerScript.cpp:193
+  assert(!CurAddressState);
+  // Tell LTO to stop inlining symbols redefined by linker script.
+  for (BaseCommand *Base : Opt.Commands)
----------------
Do not copy-n-paste the same comment all around.


https://reviews.llvm.org/D38239