[PATCH] D38170: [ELF] - Drop SHF_LINK_ORDER flag from output.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 27 21:00:51 PDT 2017
ruiu added inline comments.
================
Comment at: ELF/InputSection.cpp:97-98
+ if (!isa<InputSection>(Sec)) {
+ error("Merge and .eh_frame sections are not supported with "
+ "SHF_LINK_ORDER " + toString(Sec));
+ return nullptr;
----------------
"a section with SHF_LINK_ORDER should not refer a non-regular section: " + toString(Sec)
================
Comment at: ELF/InputSection.h:185
+ InputSection *LinkOrderSection = nullptr;
+
----------------
As always, it needs a comment.
================
Comment at: ELF/OutputSections.cpp:447
+static uint32_t getLinkOrder(ArrayRef<InputSection *> V) {
+ for (InputSection *IS : V)
----------------
This is O(N^2) where N is the number of input sections. Please don't do that.
https://reviews.llvm.org/D38170
More information about the llvm-commits
mailing list