[PATCH] D38282: llvm-dwarfdump: implement --find=<name>

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:23
 class raw_ostream;
+class DWARFFormValue;
 
----------------
Forward declaration is redundant with the above `#include`.


================
Comment at: test/tools/llvm-dwarfdump/X86/find.test:11
+CHECK: : DW_TAG_subprogram
+CHECK:     DW_AT_name ("main")
+CHECK-NOT: {{:}}
----------------
Maybe another CHECK-NOT to prove the name is associated with this subprogram?  Might be overkill but we usually do something like that.  Similarly for the MULTI cases below.



https://reviews.llvm.org/D38282