[PATCH] D38306: Cleanup some problems with LLVM_ENABLE_DUMP in release builds.

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D38306#882704, @mehdi_amini wrote:

> Ideally, I think all the headers would hide the method behind `#ifdef LLVM_ENABLE_DUMP `, so that it wouldn't be a linker failure but a compile time failure!


Yes. I think this wasn't done in the past because we did not want to have `defined(NDEBUG)` checks in the public headers because users could obviously set this flag different from what we had when LLVM was building. But as soon as we push that logic into a LLVM_ENABLE_DUMP flag and make it not depend on NDEBUG anymore we can go back to hiding the definitions in the headers as users should get the correct setting via LLVMs config.h.


Repository:
  rL LLVM

https://reviews.llvm.org/D38306