[PATCH] D38029: [AVR] Override ParseDirective

[Dylan McKay via Phabricator via llvm-commits]

dylanmckay added inline comments.


================
Comment at: lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp:125
+  case AVRMCExpr::VK_AVR_LO8_GS:
+    Value >>= 1;
+    break;
----------------
I believe we should mask out all of the upper bits here.

It looks like none of the other labels in this method do it either, which looks like a bug to me. I have filed [PR34755](https://bugs.llvm.org/show_bug.cgi?id=34755) to fix these existing ones up.

For these new expressions, can you please mask out the irrelevant bits after shifting?


================
Comment at: lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp:173
+  case VK_AVR_GS:
+    Kind = AVR::fixup_16_pm;
+    break;
----------------
Related to an earlier comment; I don't think `GS` directly maps to program memory


Repository:
  rL LLVM

https://reviews.llvm.org/D38029