[PATCH] D37686: [DAG] Consolidating Instruction->SDNode Flags propagation in one class for better code management.

[Jatin Bhateja via Phabricator via llvm-commits]

jbhateja added a comment.

In https://reviews.llvm.org/D37686#880253, @hfinkel wrote:

> In https://reviews.llvm.org/D37686#880234, @spatel wrote:
>
> > In https://reviews.llvm.org/D37686#879590, @jbhateja wrote:
> >
> > > @spatel , @reviewiews , can this land now into trunk ?
> >
> >
> > I haven't actually looked at the builder changes since you revised them, so I defer to @hfinkel is he's already approved that part.
>
>
> I don't think that I approved anything yet. I can take a holistic look at the patch later today.


@hfinkel ,  Just a reminder for review clearence.

> 
> 
>> I still don't understand why we should put the combiner changes into this patch. I'd like to see progress on using the flags too, but I think those should be separate patches with tests that cover all of the potential ambiguity that we've raised here.




https://reviews.llvm.org/D37686