[PATCH] D38299: [ARM] Honor -mfloat-abi for libcall calling convention

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

I'm happy with this change;  it matches my understanding of what gcc does as well. I think that in practice it is the users responsibility to match the compiler-rt or libgcc with their choice of mfloat-abi.



================
Comment at: test/CodeGen/Thumb2/intrinsics-cc.ll:12
 ; RUN: llc -mtriple thumbv7-unknown-none-musleabi -float-abi soft -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-MATCH
 ; RUN: llc -mtriple thumbv7-unknown-none-musleabi -float-abi hard -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-MISMATCH -check-prefix CHECK-TO-SOFT
 ; RUN: llc -mtriple thumbv7-unknown-none-musleabihf -float-abi soft -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-MISMATCH -check-prefix CHECK-TO-HARD
----------------
Can we remove the CHECK-TO-SOFT and CHECK-TO-HARD --check-prefix as it doesn't look like we have any instances of these any more?


Repository:
  rL LLVM

https://reviews.llvm.org/D38299