[PATCH] D38280: [llvm-cov] Create HTML directory structure when filtering using -name*= options

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 27 10:29:57 PDT 2017


I meant "StringRef File", not "const StringRef &File". You don't need a const reference to a StringRef, since a StringRef is conceptually already immutable and a reference.

vedant

> On Sep 27, 2017, at 8:39 AM, Sean Eveson via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL314310: [llvm-cov] Create directory structure when filtering using -name*= options (authored by seaneveson).
> 
> Changed prior to commit:
>  https://reviews.llvm.org/D38280?vs=116808&id=116820#toc
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D38280
> 
> Files:
>  llvm/trunk/test/tools/llvm-cov/Inputs/dir-with-filtering.covmapping
>  llvm/trunk/test/tools/llvm-cov/Inputs/dir-with-filtering.proftext
>  llvm/trunk/test/tools/llvm-cov/Inputs/dir-with-filtering1.cpp
>  llvm/trunk/test/tools/llvm-cov/Inputs/dir-with-filtering2.cpp
>  llvm/trunk/test/tools/llvm-cov/dir-with-filtering.test
>  llvm/trunk/test/tools/llvm-cov/showLineExecutionCounts.cpp
>  llvm/trunk/test/tools/llvm-cov/showTemplateInstantiations.cpp
>  llvm/trunk/test/tools/llvm-cov/style.test
>  llvm/trunk/tools/llvm-cov/CodeCoverage.cpp
>  llvm/trunk/tools/llvm-cov/CoverageReport.cpp
>  llvm/trunk/tools/llvm-cov/CoverageReport.h
>  llvm/trunk/tools/llvm-cov/SourceCoverageView.cpp
>  llvm/trunk/tools/llvm-cov/SourceCoverageView.h
>  llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp
>  llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.h
>  llvm/trunk/tools/llvm-cov/SourceCoverageViewText.cpp
>  llvm/trunk/tools/llvm-cov/SourceCoverageViewText.h
> 
> <D38280.116820.patch>



More information about the llvm-commits mailing list