[PATCH] D38242: [CGP] In optimizeMemoryInst handle select similarly to phi

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 27 08:54:44 PDT 2017


skatkov added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4396
   bool AddrModeFound = false;
-  bool PhiSeen = false;
+  bool PhiOrSelectSeen = false;
   SmallVector<Instruction*, 16> AddrModeInsts;
----------------
Please consider separation PhiSeen and SelectSeen, we probably will need it in future.
>From other side we can do it later if we really need it.
So it is up to you.


https://reviews.llvm.org/D38242





More information about the llvm-commits mailing list