[PATCH] D38280: [llvm-cov] Create HTML directory structure when filtering using -name*= options

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

LGTM with two changes. Thanks!



================
Comment at: tools/llvm-cov/CodeCoverage.cpp:874
+          auto &Funcs = Pos.first->second;
+          Funcs.push_back(&Function);
+        }
----------------
Could you write this as 'FilenameFunctionMap[SourceFile].push_back(&Function)'? It's a bit clearer to me.


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:881
+    for (const auto &FileFunc : FilenameFunctionMap) {
+      const std::string &File = FileFunc.first;
+      const auto &Functions = FileFunc.second;
----------------
Just StringRef


https://reviews.llvm.org/D38280