[PATCH] D38312: adding pattern for broadcastm

[Zvi Rackover via Phabricator via llvm-commits]

zvi added a comment.

The title should have an X86 label, and can you please add a cover message in the summary?



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:6695
+// if so, return the value extended.
+static SDValue isZeroExtendedVector(BuildVectorSDNode *Op, unsigned *NumElt,
+                                    MVT *EltType) {
----------------
Would isSplatZeroExtended be a better name?
(const BuildVectorSDNode *Op, unsigned &NumElts, MVT& EltType)


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:6749
 
+  // checking for broadcastm pattern
+  if (Subtarget.hasCDI() && (VT.getSizeInBits() == 512 || Subtarget.hasVLX())) {
----------------
Please add a comment explaining the change here and in the Summary. Maybe something like:
//  t0 = (zext_i64 (bitcast_i8 v2i1 X))
// t1 =  (build_vector t0 t0)
// ->
// (VBROADCASTM v2i1 X)


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:6749
 
+  // checking for broadcastm pattern
+  if (Subtarget.hasCDI() && (VT.getSizeInBits() == 512 || Subtarget.hasVLX())) {
----------------
zvi wrote:
> Please add a comment explaining the change here and in the Summary. Maybe something like:
> //  t0 = (zext_i64 (bitcast_i8 v2i1 X))
> // t1 =  (build_vector t0 t0)
> // ->
> // (VBROADCASTM v2i1 X)
Checking


https://reviews.llvm.org/D38312