[PATCH] D32844: [XRay] [compiler-rt] FDR logging arg1 handler

[Martin Pelikán via Phabricator via llvm-commits]

pelikan added inline comments.


================
Comment at: lib/xray/xray_fdr_logging.cc:293
   __xray_set_handler(fdrLoggingHandleArg0);
+  __xray_set_handler_arg1(fdrLoggingHandleArg1);
   __xray_set_customevent_handler(fdrLoggingHandleCustomEvent);
----------------
dberris wrote:
> Actually, you want to install the arg1 logging handler first, so that all the functions that have arg1 logging enabled don't sometimes use the arg0 then switch to the arg1 handler.
Good point.  Fixed and documented.


https://reviews.llvm.org/D32844