[PATCH] D38304: [MCParser] Refactory ParseDirective to add parameter OperandVector &Operands

Leslie Zhai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 20:19:26 PDT 2017


xiangzhai created this revision.
Herald added subscribers: fedor.sergeev, kbarton, javed.absar, nhaehnle, wdng, nemanjai, sdardis.

Hi LLVM developers,

Currently `ParseDirective` is able to parse `.byte foo`, but **not** able to parse `.byte lo8(foo)`, so I override `ParseDirective` to parse such Identifier Token, and `getKindByName` for `lo8` Modifier, then create `MCExpr` for this `ModifierKind`, but I can **not** able to `CreateImm` nor insert into `Operands`.

As suggested in https://reviews.llvm.org/D38029 , May I Refactory ParseDirective to add parameter `OperandVector &Operands`? please reivew my patch, and give me some suggestion, thanks a lot!

Regards,
Leslie Zhai


Repository:
  rL LLVM

https://reviews.llvm.org/D38304

Files:
  include/llvm/MC/MCParser/MCTargetAsmParser.h
  lib/MC/MCParser/AsmParser.cpp
  lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/BPF/AsmParser/BPFAsmParser.cpp
  lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
  lib/Target/Lanai/AsmParser/LanaiAsmParser.cpp
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
  lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
  lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
  lib/Target/X86/AsmParser/X86AsmParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38304.116752.patch
Type: text/x-patch
Size: 13692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170927/8c10a700/attachment.bin>


More information about the llvm-commits mailing list