[PATCH] D38260: [llvm-objcopy] Add support for removing sections

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 19:12:52 PDT 2017


jakehehrlich marked 3 inline comments as done.
jakehehrlich added inline comments.


================
Comment at: tools/llvm-objcopy/Object.h:199
 
-template <class SymTabType> class RelocationSectionBase : public SectionBase {
+class DefinedOnRelocSection : public SectionBase {
+protected:
----------------
jhenderson wrote:
> What is the purpose of this new class? Can't we just use RelocationSectionBase?
It lets me cast both to DefinedOnRelocSection so that I can handle both cases uniformly. 


Repository:
  rL LLVM

https://reviews.llvm.org/D38260





More information about the llvm-commits mailing list