[PATCH] D36073: [CGP] Extends the scope of optimizeMemoryInst optimization

[John Brawn via Phabricator via llvm-commits]

john.brawn added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:2617
   }
+  bool EqualsIgnoreBase(const ExtAddrMode &O) const {
+    return (ScaledReg == O.ScaledReg) && (BaseGV == O.BaseGV) &&
----------------
skatkov wrote:
> reames wrote:
> > mkazantsev wrote:
> > > I think this can be merged separately as NFC. Also you could re-define the `operator==` avode like `return (BaseReg == O.BaseReg) && EqualsIgnoreBase(O)` to avoid code duplication.
> > Please take Max's suggestion.  Getting this integrated is going to be a slow process and we should carve out any piece we can.
> We agreed that john.brown will implement it in a separate patch. So I 'm waiting him for this update.
This now in D38278 (plus its dependent D38242).


https://reviews.llvm.org/D36073