[PATCH] D38170: [ELF] - Drop SHF_LINK_ORDER flag from output.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D38170#880817, @ruiu wrote:

> What I meant by "drop SHF_LINK_ORDER early" is something like this: https://reviews.llvm.org/D38269
>
> This patch does not actually work and is not intended to be submitted, but I believe you can understand the idea.


Thanks for sample. Honestly dropping the flag in InputSection constructor was the first thing I tried. But I did not check
for `Link != 0` that time I think. I remember it crashed for me when accessed null section and made me think we can not access
to other sections there because them may be not initialized yet. 
So that time seems I did wrong conclusion that SHF_LINK_ORDER section was placed
earlier than its target in object from testcase that failed for me and that is why I had to add `scanLinkOrder` separatelly.
Indeed dropping flag in constructor looks much better.
Thanks again ! I am going to update this patch soon.


https://reviews.llvm.org/D38170