[PATCH] D38276: [X86] Remove dead code from X86ISelDAGToDAG.cpp multiply handling
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 26 15:30:53 PDT 2017
craig.topper added inline comments.
================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2733
- if (!SDValue(Node, 0).use_empty())
- ReplaceUses(SDValue(Node, 1),
- CurDAG->getTargetExtractSubreg(X86::sub_8bit, dl, MVT::i8, Result));
----------------
Shouldn't this ReplaceUses call have used SDValue(Node, 0)?
https://reviews.llvm.org/D38276
More information about the llvm-commits
mailing list