[PATCH] D38242: [CGP] In optimizeMemoryInst handle select similarly to phi

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 15:30:52 PDT 2017


skatkov added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4462
   // If all the instructions matched are already in this BB, don't do anything.
   // If we saw Phi node then it is not local definitely.
   if (!PhiSeen && none_of(AddrModeInsts, [&](Value *V) {
----------------
Please update at least this comment. Now the variable PhiSeen means not only Phi but also Select.


https://reviews.llvm.org/D38242





More information about the llvm-commits mailing list