[PATCH] D38265: [BypassSlowDivision] Improve our handling of divisions by constants

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 15:30:50 PDT 2017


jlebar added inline comments.


================
Comment at: lib/Transforms/Utils/BypassSlowDivision.cpp:359
+    // it stays a constant so we don't have to worry about breaking DAGCombiner
+    // optimizations on divisions by constants.
 
----------------
The divisor also stays a constant in the other two cases, so is this really the thing that makes us want to do this transformation but not the other ones when the divisor is a constant?


https://reviews.llvm.org/D38265





More information about the llvm-commits mailing list