[lld] r314204 - [ELF] - Remove wrong comment from testcase.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 06:35:00 PDT 2017


Author: grimar
Date: Tue Sep 26 06:35:00 2017
New Revision: 314204

URL: http://llvm.org/viewvc/llvm-project?rev=314204&view=rev
Log:
[ELF] - Remove wrong comment from testcase.

It was introduced by me in D37059.
Comment was saying that Weak binding is incorrect
for 'foo' symbol and that should be true for symbol in final output.
But at that place LTO temporarily file was checked,
where Weak binding for 'foo' is fine as LTO changes binding for
'LinkerRedefined' symbols internally to prevent IPO.

Binding for 'foo' in final output is correctly set to Global
and that tested just few lines below in the same testcase.

Modified:
    lld/trunk/test/ELF/lto/linker-script-symbols-assign.ll

Modified: lld/trunk/test/ELF/lto/linker-script-symbols-assign.ll
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/linker-script-symbols-assign.ll?rev=314204&r1=314203&r2=314204&view=diff
==============================================================================
--- lld/trunk/test/ELF/lto/linker-script-symbols-assign.ll (original)
+++ lld/trunk/test/ELF/lto/linker-script-symbols-assign.ll Tue Sep 26 06:35:00 2017
@@ -10,8 +10,6 @@
 ; CHECK:         Name: foo
 ; CHECK-NEXT:    Value: 0x0
 ; CHECK-NEXT:    Size: 4
-; FIXME: Binding should be Global here. Symbols redefined in script does not
-;        receive correct binding and visibility, this is a known bug.
 ; CHECK-NEXT:    Binding: Weak
 ; CHECK-NEXT:    Type: Object
 ; CHECK-NEXT:    Other: 0




More information about the llvm-commits mailing list