[PATCH] D37932: [DebugInfo] Correctly coalesce DBG_VALUEs that mix direct and indirect values

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 14:30:13 PDT 2017


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:110
+    // Fix up the undef location number, which gets truncated.
+    return LocNo == INT_MAX ? UndefLocNo : LocNo;
+  }
----------------
aprantl wrote:
> I find this confusing.. we only have 32 bits available for LocNo.. can this every fire?
s/32/31/


https://reviews.llvm.org/D37932





More information about the llvm-commits mailing list